Check all dependency jars before marking unused #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dependency might produce more than one jar (e.g. android targets produce a library jar and a resources jar). If one of those jars is unused, the current logic will mark the dependency as unused. This change only marks the dependency unused if none of the jars are used.
|
@mauriciogg can you fix the KtLint issues? |
Bencodes
reviewed
May 10, 2023
| val unusedLabels = dependencyMap.values | ||
| .filter { it.kind == Deps.Dependency.Kind.UNUSED } | ||
| .mapNotNull { readJarOwnerFromManifest(Paths.get(it.path)).label } | ||
| val kindMap = mutableMapOf<String, Deps.Dependency.Kind>() |
There was a problem hiding this comment.
@mauriciogg is there any test coverage for this behavior in JdepsMergerTest that can be added?
added 2 commits
May 11, 2023 13:46
Bencodes
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dependency might produce more than one jar (e.g. android targets produce a library jar and a resources jar). If one of those jars is unused, the current logic will mark the dependency as unused. This change only marks the dependency unused if none of the jars are used.